>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ian Maxon, Till Westmann, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450 )
Change subject: [ASTERIXDB-3155][SQL] Supporting escape backticks and singleQuote in SQL++ ...................................................................... Patch Set 7: (1 comment) File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/279384d8_7b1a8245 PS7, Line 318: else if (cray[0] == c) > what if c is cray[cray.length-1] and cray[0] is double quotes. […] since a token coming to scopeChecker function will be wrapped with a double quote so if our token is abc , it will be received as "abc" In this case, if user is writing query to include a doubleQuotes(") in their token and their token starts with a doubleQuote("), they should write it as 1. "Hello\"World" -> which will be by if block that contains switch block 2. "Hello"World" -> this is a wrong way , as lexer will consider "Hello" as token and will break when start parsing World , so the lexer will reject it first , so the highlighted else if block will not encounter it. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5d9069c6aaa1365545f7e0ca728be6ea2ca4641d Gerrit-Change-Number: 17450 Gerrit-PatchSet: 7 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Thu, 30 Mar 2023 03:16:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <[email protected]> Gerrit-MessageType: comment
