>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Till Westmann, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450 )
Change subject: [ASTERIXDB-3155][SQL] Supporting escape backticks and singleQuote in SQL++ ...................................................................... Patch Set 9: (8 comments) Commit Message: PS2: > Please check the commit message in https://asterix-gerrit.ics.uci. […] Done File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/340eab87_5752e1f2 PS7, Line 270: if (cray[0] != cray[cray.length - 1]) { : throw new IllegalStateException("Should have been caught by the lexer"); : } > not a required check since this function is called for quoted strings or > string literals. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/dc5b96e4_3b99bf18 PS7, Line 308: if (cray[0] == '\'' && c == '\'') { // if single quoted, allow '' as an escaped single quote > both works , will add both these in test cases. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/5dbdba00_4fe4f6fd PS7, Line 318: else if (cray[0] == c) > since a token coming to scopeChecker function will be wrapped with a double > quote […] Done File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/1ee1fa95_2f23b4c9 PS7, Line 5760: EscapeBackTick > To match other token naming, maybe rename to EscapeBtickWithBslash. Update it > at other places too. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/294088ce_63100da1 PS7, Line 5761: EscapeBackTickBackTick > Rename to EscapeBtickWithBtick. Update it at other places too. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/a8685beb_6e68b43e PS7, Line 5770: | <EscapeBackTick> : | <EscapeBackTickBackTick> > Is this backtick escaping needed here as this is a string literal starting > with "? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/503e6014_24a6f26c PS7, Line 5782: | <EscapeBackTick> : | <EscapeBackTickBackTick> > EscapeBtickWithBtick is not really required , but […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5d9069c6aaa1365545f7e0ca728be6ea2ca4641d Gerrit-Change-Number: 17450 Gerrit-PatchSet: 9 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Thu, 30 Mar 2023 16:09:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <[email protected]> Comment-In-Reply-To: Ritik Raj <[email protected]> Gerrit-MessageType: comment
