>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643 )
Change subject: [NO ISSUE][TX]: Multiple fixes to atomic statements ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643/comment/d21b3419_9260a6ff PS4, Line 75: 10 > why do you need this? shouldn't there be a notify every time an ack is > received? Also, is there a fa […] Updated the wait statement. The wait here will wait forever in only one situation, where JobPreparedMessage get lost i.e.,successfully sent from NC but not received at CC. However, the wait after sending commit messages can wait forever in case an NC failed before sending JobCompletionMessage. We need to add timeouts to rollback if the job completion message is not received after sending commit messages within certain time period. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb029d6273f19fa4bd0e7edfb8897f894c1f5b6e Gerrit-Change-Number: 17643 Gerrit-PatchSet: 5 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 21 Jul 2023 15:41:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
