>From Murtadha Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643 )
Change subject: [NO ISSUE][TX]: Multiple fixes to atomic statements ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643/comment/db8eba45_71cb4287 PS6, Line 296: clear I noticed that abort and clear are not synchronized calls and we usually synchronize on the opTracker for such operations to ensure stable state during these calls. This might not be an issue in atomic indexes if we have a primary index per index partition and we don't allow concurrent modifications, but make sure that there aren't other paths that cause concurrency issues if those calls aren't synchronized or see if you can make them synchronized. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17643 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb029d6273f19fa4bd0e7edfb8897f894c1f5b6e Gerrit-Change-Number: 17643 Gerrit-PatchSet: 6 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Mon, 24 Jul 2023 22:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
