>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ali Alsuliman, Hussain Towaileb. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767 )
Change subject: [ASTERIXDB-3255][RT] Prepare for embedding values in parquet ...................................................................... Patch Set 5: (9 comments) Patchset: PS5: @Ali, I marked the changes that you may have comments on @Hussain, most of the changes here are an artifact of interface changes. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataRuntimeContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/17e4db0b_af0fa73c PS5, Line 31: IExternalDataRuntimeContext @Ali File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/437855c8_f03e5298 PS5, Line 74: createExternalDataRuntimeContext @Ali File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/e6117706_c7983921 PS5, Line 48: configure @Ali File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractJsonDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/62dad72e_30b5883e PS5, Line 65: AbstractJsonDataParser @Ali File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/DelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/fa46f2ba_9292294d PS5, Line 56: DelimitedDataParser @Ali File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/cc22b13a_2943ed57 PS5, Line 65: runtimeContext @Ali File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/context/ExternalReaderRuntimeDataContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/856e400e_4650076b PS5, Line 43: throw new NullPointerException("Reader has not been set"); @Ali This is to enforce the reader is must be set before any calls to getDatasourceNameSupplier or getLineNumberSupplier File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataPrefix.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/430d943e_be90ac53 PS5, Line 290: removeProtocolContainerPair @Hussain This is used to remove s3a://bucket/ from Parquet's path. If such exists in the path, the extractValues(List<String>) doesn't work properly. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Idde191ab6d99c48022bb65bec648e83e249e4b75 Gerrit-Change-Number: 17767 Gerrit-PatchSet: 5 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 12 Sep 2023 15:18:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
