>From Wail Alkowaileet <[email protected]>:

Wail Alkowaileet has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767 )

Change subject: [ASTERIXDB-3255][RT] Prepare for embedding values in parquet
......................................................................


Patch Set 6:

(8 comments)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataRuntimeContext.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/f5a19c8a_a3dcd303
PS5, Line 31: IExternalDataRuntimeContext
> @Ali
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/888caef6_31b2f401
PS5, Line 74: createExternalDataRuntimeContext
> @Ali
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordDataParser.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/d6bb0441_2d5c163f
PS5, Line 48: configure
> @Ali
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AbstractJsonDataParser.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/930cd97e_b7dc650d
PS5, Line 65: AbstractJsonDataParser
> @Ali
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/DelimitedDataParser.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/31728915_4f8c1342
PS5, Line 56: DelimitedDataParser
> @Ali
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/1fdf019c_dfc22386
PS5, Line 65: runtimeContext
> @Ali
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/context/ExternalReaderRuntimeDataContext.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/39e8f12b_8b91ca54
PS5, Line 43: throw new NullPointerException("Reader has not been set");
> @Ali […]
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataPrefix.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767/comment/6b997f11_863370e4
PS5, Line 290: removeProtocolContainerPair
> @Hussain […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17767
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Idde191ab6d99c48022bb65bec648e83e249e4b75
Gerrit-Change-Number: 17767
Gerrit-PatchSet: 6
Gerrit-Owner: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Comment-Date: Wed, 13 Sep 2023 03:31:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wail Alkowaileet <[email protected]>
Gerrit-MessageType: comment

Reply via email to