>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778 )
Change subject: [ASTERIXDB-3263][COMP] Incorrect data inserted when optional field in closed type ...................................................................... Patch Set 6: (4 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckAndSetRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778/comment/a7824679_34b593c5 PS6, Line 255: record.numberOfFields() > FullTextContainsFunctionDescriptor.getParamTypeMap().size() * 2 Should not we remove the * 2 ? File asterixdb/asterix-app/src/test/resources/optimizerts/results/index-through-object/index-through-object.9.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778/comment/8d565987_ccae0367 PS6, Line 1: -- DISTRIBUTE_RESULT |PARTITIONED| What happened here? File asterixdb/asterix-app/src/test/resources/optimizerts/results/primary-key-index/insert-primary-key-index-with-auto-gen-pk.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778/comment/759e2539_8634a2da PS6, Line 7: -- ASSIGN |UNPARTITIONED| : -- STREAM_PROJECT |UNPARTITIONED| What's the change here? just curious. File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnionType.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778/comment/371d63e7_129443a4 PS6, Line 271: public boolean equals(Object object) { : return object instanceof IAObject && deepEqual((IAObject) object); : } Isn't this the same as the equals() of the super class AbstractComplexType? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3469da3f4f70759886fe9b98faf99eaaceff1edc Gerrit-Change-Number: 17778 Gerrit-PatchSet: 6 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Sun, 17 Sep 2023 03:37:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
