>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778 )
Change subject: [ASTERIXDB-3263][COMP] Incorrect data inserted when optional field in closed type ...................................................................... Patch Set 7: Code-Review+1 (4 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckAndSetRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778/comment/79867ad3_76d40ffb PS6, Line 255: record.numberOfFields() > FullTextContainsFunctionDescriptor.getParamTypeMap().size() * 2 > Should not we remove the * 2 ? updated File asterixdb/asterix-app/src/test/resources/optimizerts/results/index-through-object/index-through-object.9.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778/comment/678ab59b_bd550270 PS6, Line 1: -- DISTRIBUTE_RESULT |PARTITIONED| > What happened here? the query invovled is FROM Test.Users U1, Test.Users U2, [{"name": "Glenn"}] E1 LET augmentedUser1 = OBJECT_ADD(U1, "favoriteColor", "Green"), augmentedUser2 = OBJECT_ADD(U2, "favoriteFood", "Pizza"), augmentedUser3 = OBJECT_ADD(E1, "favoriteColor", "Blue") WHERE augmentedUser1.name = "John" AND augmentedUser2.name = "Sally" AND augmentedUser3.name = "Glenn" AND augmentedUser1.bestFriend = augmentedUser2.user_id SELECT *; I think {"name": "Glenn"} is constant folded causing this change. File asterixdb/asterix-app/src/test/resources/optimizerts/results/primary-key-index/insert-primary-key-index-with-auto-gen-pk.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778/comment/c7985a98_acacc917 PS6, Line 7: -- ASSIGN |UNPARTITIONED| : -- STREAM_PROJECT |UNPARTITIONED| > What's the change here? just curious. I think, for inset into ds select element {..}, there is an added cast that is causing this change File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnionType.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778/comment/9a501fce_88700848 PS6, Line 271: public boolean equals(Object object) { : return object instanceof IAObject && deepEqual((IAObject) object); : } > Isn't this the same as the equals() of the super class AbstractComplexType? removed -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17778 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3469da3f4f70759886fe9b98faf99eaaceff1edc Gerrit-Change-Number: 17778 Gerrit-PatchSet: 7 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Sun, 17 Sep 2023 05:02:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
