>From Peeyush Gupta <peeyush.gu...@couchbase.com>: Attention is currently required from: Ayush Tripathi. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854 )
Change subject: [ASTERIXDB-3277][API] Adding query queue time to stats data. ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: Please fix the test cases and address one minor comment. File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854/comment/e1c1f9bc_aae8291b PS5, Line 4781: controllerService.getJobManager().get(jobId) Please add a null check. In the rare case that JobManager.get(jobId) returns null we don't want the query to fail. Check other places where JobManager.get is used. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I1ff41693e7080abe5535c402d0dbb6b8bc387a37 Gerrit-Change-Number: 17854 Gerrit-PatchSet: 5 Gerrit-Owner: Ayush Tripathi <ayush.tripa...@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-CC: Michael Blow <mb...@apache.org> Gerrit-CC: Murtadha Hubail <mhub...@apache.org> Gerrit-Attention: Ayush Tripathi <ayush.tripa...@couchbase.com> Gerrit-Comment-Date: Tue, 10 Oct 2023 17:14:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment