>From Murtadha Hubail <[email protected]>:

Attention is currently required from: Ayush Tripathi.
Murtadha Hubail has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854 )

Change subject: [ASTERIXDB-3277][API] Adding query queue time to stats data.
......................................................................


Patch Set 5:

(2 comments)

File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854/comment/4f96214c_87fb2a43
PS5, Line 81: Duration.formatNanos
This time isn't currently in nano


File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854/comment/34856fa1_f49603e2
PS5, Line 4782: getCreateTime()
Don't do this calculation here. Add a getter in JobProfile to return the queue 
wait time with a clear unit in the name (e.g. getQueueWaitTimeInNanos()). Note 
that it is currently using millis for the creation and start times.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17854
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I1ff41693e7080abe5535c402d0dbb6b8bc387a37
Gerrit-Change-Number: 17854
Gerrit-PatchSet: 5
Gerrit-Owner: Ayush Tripathi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-CC: Michael Blow <[email protected]>
Gerrit-CC: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ayush Tripathi <[email protected]>
Gerrit-Comment-Date: Tue, 10 Oct 2023 18:19:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to