>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Peeyush Gupta, Ian Maxon. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969 )
Change subject: [ASTERIXDB-3315][RT] Exclude compression from hit ratio ...................................................................... Patch Set 2: Code-Review+2 (4 comments) Patchset: PS2: You can address those comment in a follow up change if you prefer. File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969/comment/d34bdb72_76049c51 PS2, Line 167: ICachedPage Missing @Override File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/IBufferCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969/comment/91d758bd_9ef1e23f PS2, Line 107: pin Add javaDoc File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/CompressedFileManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969/comment/f8579f59_8dcf6538 PS2, Line 314: pin Let's add a comment above explaining why incrementStats should be false (for future reference) -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I568a2df4594bdde19932ba72362c9c61291b9183 Gerrit-Change-Number: 17969 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2023 19:07:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
