>From Ian Maxon <[email protected]>: Attention is currently required from: Peeyush Gupta. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969 )
Change subject: [ASTERIXDB-3315][RT] Exclude compression from hit ratio ...................................................................... Patch Set 2: (4 comments) File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969/comment/cae7930c_a7ab28d8 PS2, Line 167: ICachedPage > Missing @Override Done File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/IBufferCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969/comment/7d14cc19_baa19a21 PS2, Line 107: pin > Add javaDoc Done File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/CompressedFileManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969/comment/dfaf1e7d_cca23602 PS2, Line 314: pin > Let's add a comment above explaining why incrementStats should be false (for > future reference) Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969/comment/10dbf8ec_00661e5d PS2, Line 314: pin > Let's add a comment above explaining why incrementStats should be false (for > future reference) Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17969 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I568a2df4594bdde19932ba72362c9c61291b9183 Gerrit-Change-Number: 17969 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2023 19:32:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
