>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990 )
Change subject: [NO ISSUE]: Move StringUtils to hyracks-api module ...................................................................... Patch Set 1: (2 comments) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990/comment/9df9e549_689f00bf PS1, Line 161: public String getMessageNoCode() { : String message = getMessage(); : return message.substring(message.indexOf(":") + 2); : } Not happy about this, it's returning the message from the HyracksException without the "HYRXXX: " part, because I wanna issue a warning, and that's what getMessage() returns. File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990/comment/a04b2cdf_cf86397c PS1, Line 52: public static Warning of(HyracksDataException ex) { : return new Warning(ex.getComponent(), ex.getSourceLocation(), ex.getErrorCode(), ex.getMessage(), : ex.getParams()); : } Ignore this, will be removed, not used -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Iea1b7db9374332315dfaf56d49f24217f7c0834c Gerrit-Change-Number: 17990 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-CC: Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 01 Dec 2023 12:09:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
