>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990 )
Change subject: [NO ISSUE]: Move StringUtils to hyracks-api module ...................................................................... Patch Set 3: (3 comments) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990/comment/5ba298de_14392138 PS1, Line 158: FUNCTION_EVALUATION_FAILED(128), > This one should go into asterix's error code probably instead of Hyracks Done File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksException.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990/comment/16acd546_7153bf9f PS1, Line 161: public String getMessageNoCode() { : String message = getMessage(); : return message.substring(message.indexOf(":") + 2); : } > Not happy about this, it's returning the message from the HyracksException > without the "HYRXXX: " pa […] Done File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990/comment/d7862a18_792bcb30 PS1, Line 52: public static Warning of(HyracksDataException ex) { : return new Warning(ex.getComponent(), ex.getSourceLocation(), ex.getErrorCode(), ex.getMessage(), : ex.getParams()); : } > Ignore this, will be removed, not used Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17990 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Iea1b7db9374332315dfaf56d49f24217f7c0834c Gerrit-Change-Number: 17990 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Comment-Date: Fri, 01 Dec 2023 16:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hussain Towaileb <[email protected]> Gerrit-MessageType: comment
