>From Ali Alsuliman <[email protected]>: Attention is currently required from: Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17997 )
Change subject: [ASTERIXDB-3327][COMP] NPE caused by offset without limit in query ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/FreeVariableVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17997/comment/2df035bd_59eb9dab PS1, Line 338: return null; Not related to this change, should we also call it on offset since offset is also an Expression? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17997 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I7b4f69d52e403674246a6a0995cfd3122e5d1b13 Gerrit-Change-Number: 17997 Gerrit-PatchSet: 1 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 02:56:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
