>From Peeyush Gupta <[email protected]>: Attention is currently required from: Ali Alsuliman. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17997 )
Change subject: [ASTERIXDB-3327][COMP] NPE caused by offset without limit in query ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/FreeVariableVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17997/comment/5ae38436_4f5cf591 PS1, Line 338: return null; > Not related to this change, should we also call it on offset since offset is > also an Expression? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17997 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I7b4f69d52e403674246a6a0995cfd3122e5d1b13 Gerrit-Change-Number: 17997 Gerrit-PatchSet: 2 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 22:47:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
