>From Ali Alsuliman <[email protected]>: Attention is currently required from: Vijay Sarathy. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18238 )
Change subject: [ASTERIXDB-3380][COMP] Internal error on a syntax error with productivity hint ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Can you add a regression test for this? File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18238/comment/15fa753f_4cdb66fd PS1, Line 720: if (hintToken.hint == null) { : throw new SqlppParseException(getSourceLocation(hintToken), "Unexpected hint"); : } I believe this will cause other valid hints to be ignored because "null" will be returned. Then the callers of "parseExpressionAnnotation()" will skip consuming the rest of the hints if the first returned hint is "null". You can try this and check: select count(1) from K1 x join K2 y on x.rand_i /*+ selectivity 0.065536 */ <= 65536 and tobigint(x.u256_i) /*+ indexnl */ /*+ productivit y 3906.25 */ = y.u256_i; -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18238 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I42399559414f94204b22897d0fae43ea8c0f54d4 Gerrit-Change-Number: 18238 Gerrit-PatchSet: 1 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Attention: Vijay Sarathy <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2024 21:08:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
