>From Vijay Sarathy <[email protected]>: Attention is currently required from: Ali Alsuliman. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18238 )
Change subject: [ASTERIXDB-3380][COMP] Internal error on a syntax error with productivity hint ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS1: > Can you add a regression test for this? Done File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18238/comment/17c22cca_3fc70781 PS1, Line 720: if (hintToken.hint == null) { : throw new SqlppParseException(getSourceLocation(hintToken), "Unexpected hint"); : } > I believe this will cause other valid hints to be ignored because "null" will > be returned. […] Have a more general solution now to handle multiple hints. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18238 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I42399559414f94204b22897d0fae43ea8c0f54d4 Gerrit-Change-Number: 18238 Gerrit-PatchSet: 3 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2024 23:33:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
