>From Hussain Towaileb <[email protected]>: Attention is currently required from: Wail Alkowaileet. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18234 )
Change subject: [ASTERIXDB-3378][EXT]: Allow user to opt out of validating write permission before COPY TO S3 ...................................................................... Patch Set 3: Code-Review+2 (3 comments) Patchset: PS3: Forwardning Wail's +2 File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18234/comment/1a0934c6_0d199940 PS2, Line 155: get > getOrDefault? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18234/comment/492abd17_c18380ce PS2, Line 156: Boolean.parseBoolean(validateWritePermissions) > This returns boolean (not Boolean). It is fine to do !Boolean. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18234 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie099710714e032674727d0cb426cc450d8dda167 Gerrit-Change-Number: 18234 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2024 06:11:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
