>From Hussain Towaileb <[email protected]>: Hussain Towaileb has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18234 )
Change subject: [ASTERIXDB-3378][EXT]: Allow user to opt out of validating write permission before COPY TO S3 ...................................................................... [ASTERIXDB-3378][EXT]: Allow user to opt out of validating write permission before COPY TO S3 Change-Id: Ie099710714e032674727d0cb426cc450d8dda167 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18234 Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Reviewed-by: Hussain Towaileb <[email protected]> --- M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Hussain Towaileb: Looks good to me, approved Jenkins: Verified; Verified Anon. E. Moose #1000171: diff --git a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java index 5faa8e1..cdaa6dc 100644 --- a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java +++ b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java @@ -151,6 +151,13 @@ } } + // do not validate write permissions if specified by the user not to do so + String validateWritePermissions = configuration + .getOrDefault(ExternalDataConstants.KEY_VALIDATE_WRITE_PERMISSION, Boolean.TRUE.toString()); + if (!Boolean.parseBoolean(validateWritePermissions)) { + return; + } + Random random = new Random(); String pathPrefix = "testFile"; String path = pathPrefix + random.nextInt(); diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java index fcdddd8..98ccbce 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java @@ -310,6 +310,7 @@ * Writer Constants */ public static final String KEY_WRITER_MAX_RESULT = "max-objects-per-file"; + public static final String KEY_VALIDATE_WRITE_PERMISSION = "validate-write-permission"; public static final String KEY_WRITER_COMPRESSION = "compression"; public static final int WRITER_MAX_RESULT_DEFAULT = 10000; public static final int WRITER_MAX_RESULT_MINIMUM = 1000; -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18234 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie099710714e032674727d0cb426cc450d8dda167 Gerrit-Change-Number: 18234 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-MessageType: merged
