>From Ali Alsuliman <[email protected]>: Attention is currently required from: Vijay Sarathy. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 )
Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly. ...................................................................... Patch Set 14: (4 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/1e0ef55b_f286b625 PS14, Line 377: Remove extra line. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/52003737_ef666d2c PS14, Line 626: applicableIndexNames != null How can this ever be 'null'? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/6ec7796b_23423954 PS14, Line 644: if (anno instanceof SecondaryIndexSearchPreferenceAnnotation) { : param1 = SecondaryIndexSearchPreferenceAnnotation.HINT_STRING; : } else if (anno instanceof IndexedNLJoinExpressionAnnotation) { : param1 = IndexedNLJoinExpressionAnnotation.HINT_STRING; : } I had a comment before about the use of instanceof and that it's not accurate. You should add an abstract method in AbstractExpressionAnnotationWithIndexNames and each subclass would just return their "HINT_STRING" File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/2816fb23_12db6bcf PS14, Line 1071: public AbstractExpressionAnnotationWithIndexNames getSecondaryIndexAnnotation We shouldn't duplicate code here. You should change (and possibly rename) the existing getSecondaryIndexPreferences to return the annotation. For the current callers of getSecondaryIndexPreferences that want the names, they can get them from the annotation itself. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 14 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Vijay Sarathy <[email protected]> Gerrit-Comment-Date: Fri, 26 Apr 2024 17:12:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
