>From Vijay Sarathy <vijay.sara...@couchbase.com>: Attention is currently required from: Ali Alsuliman. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 )
Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly ...................................................................... Patch Set 15: (5 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/d9a8368a_245911d8 PS14, Line 377: > Remove extra line. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/da114869_d592e0b4 PS14, Line 564: || (annotationRemoved && (this instanceof IntroduceJoinAccessMethodRule)) > Take it to an else part and then call: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/0ce78c41_baccfe40 PS14, Line 626: applicableIndexNames != null > How can this ever be 'null'? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/ca28ba84_d250ba6f PS14, Line 644: if (anno instanceof SecondaryIndexSearchPreferenceAnnotation) { : param1 = SecondaryIndexSearchPreferenceAnnotation.HINT_STRING; : } else if (anno instanceof IndexedNLJoinExpressionAnnotation) { : param1 = IndexedNLJoinExpressionAnnotation.HINT_STRING; : } > I had a comment before about the use of instanceof and that it's not > accurate. […] Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/7dabd039_74682b7f PS14, Line 1071: public AbstractExpressionAnnotationWithIndexNames getSecondaryIndexAnnotation > We shouldn't duplicate code here. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 15 Gerrit-Owner: Vijay Sarathy <vijay.sara...@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Vijay Sarathy <vijay.sara...@couchbase.com> Gerrit-CC: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Comment-Date: Sat, 27 Apr 2024 22:03:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
