>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ritik Raj. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388 )
Change subject: [ASTERIXDB-3439][STO] Exposing cloud read metrics ...................................................................... Patch Set 3: (5 comments) File hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/buffercache/context/DefaultCloudReadContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/d1738561_a8bfa8ac PS3, Line 111: cloudRead This is also a cloud read File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/buffercache/read/CloudColumnReadContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/d245f3a6_67c57f55 PS3, Line 113: if (threadStats != null) { : threadStats.cloudPageRead(); : } That's not a cloud read. Cloud read could be in readAndPersistPage but not necessary. See my comment in DefaultCloudReadContext File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/buffercache/read/CloudMegaPageReadContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/d49a5b17_5f4aac66 PS3, Line 189: if (threadStats != null) { Not your fault, buy those checks are super ugly! See my comment in BufferCache. We should have a no-op threadStats, where cloudPagePersist() and friends should do nothing https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/5450970d_93267409 PS3, Line 190: cloudPageRead Move this to doStreamRead File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/2434d86f_7211ac2b PS3, Line 570: get Create a new class NoOpThreadStats. This should be a singleton class. The constructor is private and NoOpThreadStats should have a single instance as public static final IThreadStats INSTANCE = new NoOpThreadStats(); Use getOrDefault(Thread.currentThread(), NoOpThreadStats.INSTANCE); -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5d547e4267ec93c97f7b5398ce925fbb73262010 Gerrit-Change-Number: 18388 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Mon, 24 Jun 2024 21:54:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
