>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail, Wail Alkowaileet. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388 )
Change subject: [ASTERIXDB-3439][STO] Exposing cloud read metrics ...................................................................... Patch Set 4: (6 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/a45bfc4d_eeff7922 PS3, Line 44: CLOUD_REQUESTS_COUNT > You should rename those to match too Done File hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/buffercache/context/DefaultCloudReadContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/b4aab452_dde085a5 PS3, Line 111: cloudRead > This is also a cloud read Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/buffercache/read/CloudColumnReadContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/3a8e698c_e91fb5c7 PS3, Line 113: if (threadStats != null) { : threadStats.cloudPageRead(); : } > That's not a cloud read. Cloud read could be in readAndPersistPage but not > necessary. […] Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/buffercache/read/CloudMegaPageReadContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/0df7282e_a75cb73c PS3, Line 189: if (threadStats != null) { > Not your fault, buy those checks are super ugly! See my comment in > BufferCache. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/7f62c0aa_d38deaff PS3, Line 190: cloudPageRead > Move this to doStreamRead Done File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388/comment/f795ccc9_82e1e589 PS3, Line 570: get > Create a new class NoOpThreadStats. This should be a singleton class. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18388 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5d547e4267ec93c97f7b5398ce925fbb73262010 Gerrit-Change-Number: 18388 Gerrit-PatchSet: 4 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Tue, 25 Jun 2024 12:30:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
