>From Ali Alsuliman <[email protected]>:
Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ali
Alsuliman, Michael Blow.
Hello Murtadha Hubail, Peeyush Gupta, Wail Alkowaileet, Jenkins, Michael Blow,
Anon. E. Moose #1000171,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445
to look at the new patch set (#7).
Change subject: [ASTERIXDB-3446][RT] cast enhancements
......................................................................
[ASTERIXDB-3446][RT] cast enhancements
- user model changes: no
- storage format changes: no
- interface changes: yes
Details:
- Avoid allocating pointable objects for all values at once.
Instead, allocate for one value at a time and free object
to make it re-usable for the next value.
- Avoid copying the data from the original input to buffers.
Instead, maintain indexes pointing to the positions of values.
When a value is needed, it will be looked up using the indexes.
Change-Id: Id7945b8d595353f1ea82ba3f1cc87f35ee8055a2
---
A
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordCastingPointable.java
A
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/base/ICastingPointable.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/RecordBuilder.java
A
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/AbstractCastingPointable.java
A
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ACastingPointableVisitor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeLaxEvaluator.java
A
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/AFlatValueCastingPointable.java
A
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/visitor/ICastingPointableVisitor.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/IARecordBuilder.java
A
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/AListCastingPointable.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CastTypeEvaluator.java
11 files changed, 1,218 insertions(+), 34 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/45/18445/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Id7945b8d595353f1ea82ba3f1cc87f35ee8055a2
Gerrit-Change-Number: 18445
Gerrit-PatchSet: 7
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-MessageType: newpatchset
