>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Wail Alkowaileet, Michael Blow. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445 )
Change subject: [ASTERIXDB-3446][RT] cast enhancements ...................................................................... Patch Set 7: Code-Review+1 (4 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordCastingPointable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445/comment/67c9165b_0cc77bf2 PS6, Line 217: IllegalStateException > Could use a message Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445/comment/bcb27548_30602e19 PS6, Line 443: quickSort > Maybe consider using IntArrays from fastutil? They have a bunch of sort > algorithms there (you can pr […] Ack. Will do in a follow-up patch. File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ACastingPointableVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445/comment/8c295383_b369e38a PS6, Line 141: needPromote > Flip a logic to avoid '!' Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445/comment/c27ad2aa_531512a3 PS6, Line 159: needPromote > This means both promote/demote, right? Ack -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18445 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id7945b8d595353f1ea82ba3f1cc87f35ee8055a2 Gerrit-Change-Number: 18445 Gerrit-PatchSet: 7 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2024 18:55:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
