>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Murtadha Hubail, Michael Blow, Hussain Towaileb, Mohammad Nawazish Khan. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235 )
Change subject: ASTERIXDB-3379 Provide Azure Blob Storage support for the Engine ...................................................................... Patch Set 29: (3 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3CloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235/comment/a51dcf0f_d4177a34 PS29, Line 95: DefaultCloudRequestRateLimiter limiter = new DefaultCloudRequestRateLimiter(config.getTokenAcquireTimeout(), : config.getWriteMaxRequestsPerSeconds(), config.getReadMaxRequestsPerSeconds()); Revert to the original implementation File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzParallelDownloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235/comment/44f858fa_ae3ce22c PS29, Line 45: AzParallelDownloader Use the full name "Azure" File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/profiler/DefaultCloudRequestRateLimiter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235/comment/40b2e50b_bf3b7be6 PS29, Line 26: DefaultCloudRequestRateLimiter This should not be used in Azure or GCS as this implementation is S3 specific. Please revert this change and have another implementation for Azure. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie9deece8ba98a5b8be7c817baea286cd50d88e68 Gerrit-Change-Number: 18235 Gerrit-PatchSet: 29 Gerrit-Owner: Mohammad Nawazish Khan <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Attention: Mohammad Nawazish Khan <[email protected]> Gerrit-Comment-Date: Tue, 30 Jul 2024 10:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
