>From Mohammad Nawazish Khan <[email protected]>: Attention is currently required from: Murtadha Hubail, Wail Alkowaileet, Michael Blow, Hussain Towaileb. Mohammad Nawazish Khan has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235 )
Change subject: ASTERIXDB-3379 Provide Azure Blob Storage support for the Engine ...................................................................... Patch Set 35: (3 comments) This change is ready for review. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3CloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235/comment/a556c511_8b24b0ce PS29, Line 95: DefaultCloudRequestRateLimiter limiter = new DefaultCloudRequestRateLimiter(config.getTokenAcquireTimeout(), : config.getWriteMaxRequestsPerSeconds(), config.getReadMaxRequestsPerSeconds()); > Revert to the original implementation Done File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzParallelDownloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235/comment/9a6513b4_ba158491 PS29, Line 45: AzParallelDownloader > Use the full name "Azure" Done File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/profiler/DefaultCloudRequestRateLimiter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235/comment/467d9c1b_88ce0899 PS29, Line 26: DefaultCloudRequestRateLimiter > This should not be used in Azure or GCS as this implementation is S3 > specific. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18235 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie9deece8ba98a5b8be7c817baea286cd50d88e68 Gerrit-Change-Number: 18235 Gerrit-PatchSet: 35 Gerrit-Owner: Mohammad Nawazish Khan <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 19:45:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
