>From Wail Alkowaileet <[email protected]>: Attention is currently required from: [email protected]. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663 )
Change subject: [ASTERIXDB-3392] Add new FieldNamesDictionary ...................................................................... Patch Set 2: (5 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetOutputFile.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/9cc6ad30_b8e90bcf PS2, Line 33: // This class wraps OutputStream as a file that Parquet SDK supports writing to. : // By default, this assumes output stream doesn't support block size which distributed file systems use. : // Hadoop File System Library use this as a default block size : // Ref : https://github.com/apache/hadoop/blob/74ff00705cf67911f1ff8320c6c97354350d6952/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L2756 Use a multi-line comment /* .... */ File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/parquet/FieldNamesDictionary.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/78874ecd_7723a059 PS2, Line 43: UTF8StringUtil.toString(pointable.getByteArray(), pointable.getStartOffset()); Check how we serialize a string using AStringSerializerDeserializer. See how the 'ParserContext' does it. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/parquet/ParquetValueWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/7be7e505_4d84cbd4 PS2, Line 46: ParquetValueWriterUtils parquetValueWriterUtils remove https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/c9a4cf52_e2a287e0 PS2, Line 57: static class ParquetValueWriterUtils Inline the method of this class. I.e., no utils needed. Make those method in the same class. There's no reason to have a nested class here. File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/metadata/AbstractFieldNamesDictionary.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/9f26c5fe_5651aa7c PS2, Line 19: metadata change to dictionary -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I798fcb4a02f017ad1b31e0cdb556e0dda1403b5e Gerrit-Change-Number: 18663 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Tue, 13 Aug 2024 14:22:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
