>From <[email protected]>: Attention is currently required from: Wail Alkowaileet. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663 )
Change subject: [ASTERIXDB-3392] Add new FieldNamesDictionary ...................................................................... Patch Set 5: Code-Review+1 (5 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetOutputFile.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/d71314a3_ebeac47f PS2, Line 33: // This class wraps OutputStream as a file that Parquet SDK supports writing to. : // By default, this assumes output stream doesn't support block size which distributed file systems use. : // Hadoop File System Library use this as a default block size : // Ref : https://github.com/apache/hadoop/blob/74ff00705cf67911f1ff8320c6c97354350d6952/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L2756 > Use a multi-line comment /* .... […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/parquet/FieldNamesDictionary.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/199ab8f1_db7789f5 PS2, Line 43: UTF8StringUtil.toString(pointable.getByteArray(), pointable.getStartOffset()); > Check how we serialize a string using AStringSerializerDeserializer. […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/parquet/ParquetValueWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/c8116d29_ed6e2e60 PS2, Line 46: ParquetValueWriterUtils parquetValueWriterUtils > remove Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/c03d65ec_fd2f688b PS2, Line 57: static class ParquetValueWriterUtils > Inline the method of this class. I.e., no utils needed. Make those method in > the same class. […] Done File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/metadata/AbstractFieldNamesDictionary.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663/comment/094c39c3_a206fe07 PS2, Line 19: metadata > change to dictionary Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18663 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I798fcb4a02f017ad1b31e0cdb556e0dda1403b5e Gerrit-Change-Number: 18663 Gerrit-PatchSet: 5 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2024 07:06:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
