>From Savyasach Reddy <[email protected]>: Attention is currently required from: Wail Alkowaileet. Savyasach Reddy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18645 )
Change subject: [NO ISSUE]: Add Guardian to GCSWriter, Request Limits for GCS ...................................................................... Patch Set 4: (1 comment) This change is ready for review. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18645/comment/6f22132a_bf722e47 PS4, Line 125: writer.setChunkSize(writeBufferSize); Should the chunk size be writeBufferSize? Should GCSCloudClient#getWriteBufferSize return 0, as we don't need a writeBufferProvider for GCS? https://cloud.google.com/java/docs/reference/google-cloud-core/latest/com.google.cloud.WriteChannel#com_google_cloud_WriteChannel_setChunkSize_int_ -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18645 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id639afcadb1d88b4630e12dde40dbaae94e15f23 Gerrit-Change-Number: 18645 Gerrit-PatchSet: 4 Gerrit-Owner: Savyasach Reddy <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2024 17:48:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
