>From Savyasach Reddy <[email protected]>:

Attention is currently required from: Wail Alkowaileet.
Savyasach Reddy has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18645 )

Change subject: [NO ISSUE]: Add Guardian to GCSWriter, Request Limits for GCS
......................................................................


Patch Set 4:

(2 comments)

File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/cloud_storage/CloudStorageGCSTest.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18645/comment/6355f5ee_4466ab7e
PS4, Line 57: CloudStorageGCSTest
> We need to do a random sample, we cannot sustain running all queries 
> everytime we support a new clou […]
Ack


File 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSWriter.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18645/comment/ebf2e44f_f12c3823
PS4, Line 125:             writer.setChunkSize(writeBufferSize);
> Let's keep as is. It won't be used anyway.
Ack



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18645
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Id639afcadb1d88b4630e12dde40dbaae94e15f23
Gerrit-Change-Number: 18645
Gerrit-PatchSet: 4
Gerrit-Owner: Savyasach Reddy <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Wail Alkowaileet <[email protected]>
Gerrit-Comment-Date: Wed, 14 Aug 2024 05:23:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wail Alkowaileet <[email protected]>
Comment-In-Reply-To: Savyasach Reddy <[email protected]>
Gerrit-MessageType: comment

Reply via email to