>From Ali Alsuliman <[email protected]>: Attention is currently required from: [email protected]. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401 )
Change subject: [NO ISSUE][COMP] Honor select-list field order ...................................................................... Patch Set 13: (1 comment) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401/comment/027b3532_71757eac PS13, Line 240: String openFieldName = UTF8StringUtil : .toString(new StringBuilder(), dataBos.getByteArray(), fnstart + 1).toString(); This will become expensive since it will be done for every open field for every tuple of the result. Also, it is doing it for any ARecordVisitablePointable regardless whether it's a ARecordVisitablePointable used by result's tuple or a ARecordVisitablePointable that happens to be used by the functions and operators throughout the query plan. In other words, we should only do this for the ARecordVisitablePointable used in result's tuple. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080e581b92744ddd9090b291936513c75af Gerrit-Change-Number: 18401 Gerrit-PatchSet: 13 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Fri, 23 Aug 2024 00:37:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
