>From <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman. [email protected] has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401 )
Change subject: [NO ISSUE][COMP] Honor select-list field order ...................................................................... Patch Set 15: (5 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401/comment/efc3a684_e1df9e3c PS14, Line 74: private final List<IVisitablePointable> openFieldLocator = new ArrayList<>(); : private final List<IVisitablePointable> closedFieldLocator = new ArrayList<>(); : private final List<IVisitablePointable> orderedFields = new ArrayList<>(); > It seems that all of these can be created conditionally (i.e. only when there > is order). […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401/comment/f5394f04_1abc2043 PS14, Line 271: Integer > Let's return primitive int instead of Integer. Done File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401/comment/81c127b9_4c435ee8 PS14, Line 65: if (orderedFields == null) { > Isn't this always going to be false since you always create orderedFields in > ARecordVisitablePointab […] Changed in ARecordVisitablePointables to set this field conditionally. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401/comment/8c70c4d9_f93e91b3 PS14, Line 71: boolean[] printed = new boolean[size]; > Let's get rid of this to avoid creating (garbage) objects with every printed > record. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401/comment/8bf0575c_94c0f5a5 PS14, Line 81: for (int i = 0; i < size; ++i) { > This now can be replaced with: […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18401 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080e581b92744ddd9090b291936513c75af Gerrit-Change-Number: 18401 Gerrit-PatchSet: 15 Gerrit-Owner: [email protected] Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2024 08:08:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
