>From Savyasach Reddy <[email protected]>: Attention is currently required from: Hussain Towaileb. Savyasach Reddy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066 )
Change subject: [ASTERIXDB-3519][EXT]: Support dynamic prefixes on HDFS ...................................................................... Patch Set 5: (3 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066/comment/2d0e3639_874b2938 PS3, Line 153: (ExternalDataConstants.KEY_HADOOP_INPUT_DIR, ""); > hdfsConf.set(ExternalDataConstants.KEY_HADOOP_INPUT_DIR, "/") is returning > all the files. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066/comment/a2918f38_1fc18b0f PS3, Line 158: hdfsConf.set(ExternalDataConstants.KEY_HADOOP_INPUT_DIR, ""); > Ideally, we should do the same, but wouldn't the continuation of the > execution fail? After all, HDFS […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066/comment/a5dddff3_84764640 PS4, Line 162: "No files found at the given path" > Why not use ErrorCode. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdbcd44c059f64f2da436a40ac3f59293442cf2 Gerrit-Change-Number: 19066 Gerrit-PatchSet: 5 Gerrit-Owner: Savyasach Reddy <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Hussain Towaileb <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 19:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hussain Towaileb <[email protected]> Comment-In-Reply-To: Savyasach Reddy <[email protected]> Gerrit-MessageType: comment
