>From Savyasach Reddy <[email protected]>: Attention is currently required from: Hussain Towaileb. Savyasach Reddy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066 )
Change subject: [ASTERIXDB-3519][EXT]: Support dynamic prefixes on HDFS ...................................................................... Patch Set 7: (2 comments) File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_external_dataset_s3.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066/comment/3619ed69_477e9227 PS4, Line 30: <placeholder name="pathprefix" value="" /> : <placeholder name="path_prefix" value="" /> > You probably could reduce these by implementing that a missing value of a > placeholder means it passe […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/HDFSUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066/comment/25372790_099c9b03 PS4, Line 590: Objects.equals(ExternalDataConstants.KEY_ADAPTER_NAME_HDFS, : configuration.get(ExternalDataConstants.KEY_EXTERNAL_SOURCE_TYPE)); > Instead do: […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdbcd44c059f64f2da436a40ac3f59293442cf2 Gerrit-Change-Number: 19066 Gerrit-PatchSet: 7 Gerrit-Owner: Savyasach Reddy <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Hussain Towaileb <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2024 11:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hussain Towaileb <[email protected]> Gerrit-MessageType: comment
