>From Hussain Towaileb <[email protected]>: Attention is currently required from: Savyasach Reddy. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066 )
Change subject: [ASTERIXDB-3519][EXT]: Support dynamic prefixes on HDFS ...................................................................... Patch Set 8: Verified+1 Code-Review+2 (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066/comment/ff8d132f_79e87954 PS6, Line 5766: String adapterModifiedCase = ExternalDataConstants.EXTERNAL_READ_ADAPTERS.stream() : .filter(k -> k.equalsIgnoreCase(adapter)).findFirst().orElse(adapter); : externalDetails.setAdapter(adapterModifiedCase); Let's move this to normalize and include all adapters. Put a comment there stating that this will check the provided adapter with case-sensitivity, and if valid, will use the constant we have for it. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19066 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I1bdbcd44c059f64f2da436a40ac3f59293442cf2 Gerrit-Change-Number: 19066 Gerrit-PatchSet: 8 Gerrit-Owner: Savyasach Reddy <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Savyasach Reddy <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2024 16:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
