>From Mohammad Nawazish Khan <[email protected]>: Attention is currently required from: Ayush Tripathi, Ali Alsuliman. Mohammad Nawazish Khan has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206 )
Change subject: [ASTERIXDB-3537][COMP] Support truncate Dataset Statements ...................................................................... Patch Set 14: (6 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/b7290218_d083cec4 PS14, Line 2387: TruncateDatasetStatement stmtDelete = (TruncateDatasetStatement) stmt; query on variable name "stmtDelete": would it be more apt to name the variable as truncStmt or stmtTruc as this is necessarily a truncate statement? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/14cf4b76_9ce6d864 PS14, Line 2441: if (dv == null) { Refactor: The handling of scenario when dataverse == null could be given a separate method. It would reduce the size of doTruncateDataset and give a good abstraction to the handling of different scenarios handled within that block. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/9f52728b_0e72d48a PS14, Line 2455: if (ds == null) { Refactor: Similar observations as above (when dataset == null) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/a773d794_928648d1 PS14, Line 2475: LOGGER.error("failed to Truncate dataset", e); Query: The error message contained in "e" might be appended right after the log message "...dataset". Do you want to give a space gap there? File asterixdb/asterix-app/src/test/resources/runtimets/results/ddl/truncate-dataset-1/truncate-dataset-1.06.adm: PS14: Empty file? File asterixdb/asterix-app/src/test/resources/runtimets/results/ddl/truncate-dataset-1/truncate-dataset-1.07.adm: PS14: Empty file? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia476bd12832cac4a958de67d75cde03d17efa405 Gerrit-Change-Number: 19206 Gerrit-PatchSet: 14 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Mohammad Nawazish Khan <[email protected]> Gerrit-Attention: Ayush Tripathi <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2025 09:55:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
