>From Ayush Tripathi <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ali Alsuliman. Ayush Tripathi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206 )
Change subject: [ASTERIXDB-3537][COMP] Support truncate Dataset Statements ...................................................................... Patch Set 16: (14 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/43ac7811_d0ca8a4d PS15, Line 64: CompiledDatasetTruncateStatement > Where is this used? Remove if not used. Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/f49a1885_706cd08a PS15, Line 2385: handleDatasetTruncateStatement > This needs to be overridden in extensions to do the proper/usual handling. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/bffecc61_96893022 PS15, Line 2396: dropDatasetBegin > Add a new method called "truncateDatasetBegin". The logic should be the same > as dropDatasetBegin. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/5512dc89_5dd1398a PS15, Line 2464: ds.truncate(metadataProvider, ds); > You are calling a method on 'ds' and also passing 'ds' as an argument which > looks weird. […] Done File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/truncate-dataset-1/truncate-dataset.01.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/b5b7457f_e5bd0765 PS15, Line 26: create dataset orders if not exists primary key (my_id: string); > This is duplicate. Done File asterixdb/asterix-doc/src/main/grammar/sqlpp.ebnf: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/704f8bd4_f74cfc00 PS15, Line 254: ("DATAVERSE" DataverseName > TRUNCATE should only be followed by "DATASET". […] Done File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/TruncateDatasetStatement.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/defc0fe3_f26df19c PS15, Line 68: DDL > It feels like this should be UPDATE. […] Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/b12f81a8_2bde3ddf PS15, Line 378: truncate > We should only allow truncate only INTERNAL && atomic datasets, else fail (or > return a warning). DatasetUtils now contains truncate, it checks for INTERNAL datasets. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/182d9dd9_2a51a4df PS15, Line 385: dcpSateWriteOp > truncateOp Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/997db185_d5cb49d5 PS15, Line 826: Can't rollback the analytics collection > Can't truncate the collection Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/FullRollbackOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/7f0f4414_8668ed62 PS15, Line 60: FullRollbackOperatorDescriptor > Change this to TruncateOperatorDescriptor Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/25ab90c8_f4c59492 PS15, Line 109: Fully rolledback dataset > Truncated collection {} ... Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/26754989_701615e3 PS15, Line 120: rollback > truncate Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206/comment/4ad37ea1_cc6758c9 PS15, Line 162: rollback > truncate Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19206 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia476bd12832cac4a958de67d75cde03d17efa405 Gerrit-Change-Number: 19206 Gerrit-PatchSet: 16 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Mohammad Nawazish Khan <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 06:24:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
