Yingyi Bu has posted comments on this change. Change subject: Exceptions Cleanup for Replication/FaultTolerance Strategies ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1529/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IRecoveryManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IRecoveryManager.java: PS2, Line 38: checkpoint I'm confused here. NEW_UNIVERSE doesn't mean that it's a fresh instance? It meant for that from the very beginning. At least, the name "NEW_UNIVERSE" doesn't seem to match that state. Can you use "NEW_UNIVERSE" for the current "INITIAL_RUN", and use "DATA_LOSS" for the current "NEW_UNIVERSE"? https://asterix-gerrit.ics.uci.edu/#/c/1529/2/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: PS2, Line 52: error A more concrete error message? A user still cannot know the root cause via this error message. -- To view, visit https://asterix-gerrit.ics.uci.edu/1529 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f28b8db42bf7c8537ff2da22cbd2a97e243f32f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
