Till Westmann has posted comments on this change. Change subject: Exceptions Cleanup for Replication/FaultTolerance Strategies ......................................................................
Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1529/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IRecoveryManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IRecoveryManager.java: PS3, Line 38: PERMANENT_DATA_LOSS This sounds rather harsh compared to "NEW_UNIVERSE" - a good change :) https://asterix-gerrit.ics.uci.edu/#/c/1529/3/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: PS3, Line 51: Instantiation Having a new "section" here seems a little too tight - especially as there probably many more "Data errors" and only a few "Instantiation errors" that still need to be added. Maybe we just start at 100? -- To view, visit https://asterix-gerrit.ics.uci.edu/1529 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f28b8db42bf7c8537ff2da22cbd2a97e243f32f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
