>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Hubail, Ayush Tripathi, Ali Alsuliman. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306 )
Change subject: [ASTERIXDB-3365][EXT] Revisiting Avro logical types ...................................................................... Patch Set 5: (6 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AvroDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/08c87fc0_74aefb1d PS5, Line 224: INTEGER shouldn't this be BIGINT as well https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/d0ed5911_03a81413 PS5, Line 281: if You can change this to else if as well. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/38486120_a54dba11 PS5, Line 296: serializeInt shouldn't this be serializeLong https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/39f93ed8_fe3d6440 PS5, Line 330: } Should there be an else with an error saying unsupported or invalid logical type ? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/1c08d1b9_cb7ba8a2 PS5, Line 391: aInt64.setValue(intValue); shouldn't this be aInt32 if we are serializing an int value? Or do you want to serialize an integer value as long? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/e3d08e65_6dc8c6d9 PS5, Line 409: PARQUET_SUPPORTED_TYPE_WITH_OPTION This will return an error message saying Parquet unsupported type ... Create a new error code or change to a different one. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I6ce5d7f7c3deac986abd416583133475d1f86f27 Gerrit-Change-Number: 19306 Gerrit-PatchSet: 5 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ayush Tripathi <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 21:08:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
