>From Ayush Tripathi <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ali Alsuliman. Ayush Tripathi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306 )
Change subject: [ASTERIXDB-3365][EXT] Revisiting Avro logical types ...................................................................... Patch Set 6: (12 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AvroDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/c1d618f4_a2990c69 PS5, Line 224: INTEGER > shouldn't this be BIGINT as well Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/99140d7f_f07116bc PS5, Line 224: INTEGER > shouldn't this be BIGINT as well Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/26c8e332_b010bae4 PS5, Line 281: if > You can change this to else if as well. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/fe18f2f0_6eeeaa6d PS5, Line 281: if > You can change this to else if as well. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/54238156_edc1c4b1 PS5, Line 296: serializeInt > shouldn't this be serializeLong Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/6fdfaf3a_68d1350b PS5, Line 296: serializeInt > shouldn't this be serializeLong fixed https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/a432c6d8_e953115c PS5, Line 330: } > Should there be an else with an error saying unsupported or invalid logical > type […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/268b3b9c_2413c8f3 PS5, Line 330: } > Should there be an else with an error saying unsupported or invalid logical > type […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/5dde22ab_c48c1cb9 PS5, Line 391: aInt64.setValue(intValue); > shouldn't this be aInt32 if we are serializing an int value? Or do you want > to serialize an integer […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/096dcf1b_10a45518 PS5, Line 391: aInt64.setValue(intValue); > shouldn't this be aInt32 if we are serializing an int value? Or do you want > to serialize an integer […] Earlier int,long both were parsed to long, changed that in latest patch. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/828505cd_a36d87fa PS5, Line 409: PARQUET_SUPPORTED_TYPE_WITH_OPTION > This will return an error message saying Parquet unsupported type ... […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306/comment/d3dacb5d_b841bd67 PS5, Line 409: PARQUET_SUPPORTED_TYPE_WITH_OPTION > This will return an error message saying Parquet unsupported type ... […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19306 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I6ce5d7f7c3deac986abd416583133475d1f86f27 Gerrit-Change-Number: 19306 Gerrit-PatchSet: 6 Gerrit-Owner: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ayush Tripathi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2025 08:07:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <[email protected]> Gerrit-MessageType: comment
