>From Hussain Towaileb <[email protected]>: Attention is currently required from: Murtadha Hubail, Michael Blow. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246 )
Change subject: [ASTERIXDB-3514][EXT]: Support trust auth for parquet + delete assumed creds on collection drop ...................................................................... Patch Set 11: Verified+1 Code-Review+2 Integration-Tests+1 (7 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalCredentialsCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/20870ad2_476b36be PS7, Line 43: refreshAwsAssumeRolePercentage > rename to refreshAwsAssumeRoleThreshold Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/0104dc66_7eba263d PS7, Line 2452: String.join(".", databaseName, dataverseName.getCanonicalForm(), datasetName) > This is error prune. […] Will address in a follow up patch. File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/70db144a_d9f99e9f PS7, Line 62: AWS_REFRESH_ASSUME_ROLE_PERCENTAGE > rename to AWS_REFRESH_ASSUME_ROLE_THRESHOLD Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3AuthUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/2c17dc0a_d072fa80 PS7, Line 382: if (serviceEndpoint != null) > Set the region property manually as well, we always have it Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Constants.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/7a04b9cd_c782f4cf PS7, Line 38: assumeRoleRefreshPercentage > assumeRoleRefreshThreshold Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/47dd4f25_14be0d08 PS7, Line 50: AWS connectors for s3 and s3n are deprecated. > Check if we're still using s3 or s3n anywhere, might have all been replaced > to use s3a Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/c51ffdef_cc3703e3 PS7, Line 59: public static final String HADOOP_REGION = "fs.s3a.region"; > Currently unused, S3 probably uses bucket region detection to know the right > location, set this if a […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I77998a5dfcc304692e12280b7b4018f3593085b9 Gerrit-Change-Number: 19246 Gerrit-PatchSet: 11 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2025 17:13:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Hussain Towaileb <[email protected]> Gerrit-MessageType: comment
