>From Hussain Towaileb <[email protected]>:

Hussain Towaileb has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246 )

Change subject: [ASTERIXDB-3514][EXT]: Support trust auth for parquet + delete 
assumed creds on collection drop
......................................................................


Patch Set 12:

(2 comments)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3AuthUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/ad88bcfe_d6bd7857
PS7, Line 421:                 jobConf.set(HADOOP_ASSUME_ROLE_SESSION_DURATION, 
"15m");
> Range that hadoop supports is 15m to 1h (in this format), We should compare 
> it to what's configured  […]
Will do in follow up


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246/comment/0c7d700c_133295fe
PS7, Line 423: // TODO: this assumes basic keys always, also support if we use 
InstanceProfile to assume a role
> We can use the following to assume a role, support them all: […]
Will do in follow up



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19246
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I77998a5dfcc304692e12280b7b4018f3593085b9
Gerrit-Change-Number: 19246
Gerrit-PatchSet: 12
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Comment-Date: Fri, 17 Jan 2025 17:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hussain Towaileb <[email protected]>
Gerrit-MessageType: comment

Reply via email to