Till Westmann has posted comments on this change. Change subject: Ansible scripts for local cluster installtion. ......................................................................
Patch Set 10: Code-Review+2 (3 comments) Change looks good, only cosmetic comments. Tried the local install using ansible, but shied away from running erase.sh on my box ... https://asterix-gerrit.ics.uci.edu/#/c/1525/10//COMMIT_MSG Commit Message: PS10, Line 7: installtion s/installtion/installation/ https://asterix-gerrit.ics.uci.edu/#/c/1525/10/asterixdb/asterix-server/src/main/opt/ansible/bin/erase.sh File asterixdb/asterix-server/src/main/opt/ansible/bin/erase.sh: PS10, Line 30: TODO file an issue instead of shipping this TODO? https://asterix-gerrit.ics.uci.edu/#/c/1525/10/asterixdb/asterix-server/src/main/opt/ansible/bin/stop.sh File asterixdb/asterix-server/src/main/opt/ansible/bin/stop.sh: Line 21: Only one empty line? Looking at the similarity of the scripts, I wonder if we should try to factor some lines out. But possibly that just makes the script more complicated. Maybe we can discuss this later. -- To view, visit https://asterix-gerrit.ics.uci.edu/1525 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f6f198c9ce41d7d7667dc4fbc21b3e34a77ab Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
