Yingyi Bu has posted comments on this change.

Change subject: Ansible scripts for local cluster installation.
......................................................................


Patch Set 11:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1525/10//COMMIT_MSG
Commit Message:

PS10, Line 7: installatio
> s/installtion/installation/
Done


https://asterix-gerrit.ics.uci.edu/#/c/1525/10/asterixdb/asterix-server/src/main/opt/ansible/bin/erase.sh
File asterixdb/asterix-server/src/main/opt/ansible/bin/erase.sh:

PS10, Line 30: TODO
> file an issue instead of shipping this TODO?
Done. Created ASTERIXDB-1814.


https://asterix-gerrit.ics.uci.edu/#/c/1525/10/asterixdb/asterix-server/src/main/opt/ansible/bin/stop.sh
File asterixdb/asterix-server/src/main/opt/ansible/bin/stop.sh:

Line 21: # Gets the absolute path so that the script can work no matter where 
it is invoked.
> Only one empty line?
Removed the empty line.

Sure. Opened ASTERIXDB-1815 for that.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1525
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I310f6f198c9ce41d7d7667dc4fbc21b3e34a77ab
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyin...@gmail.com>
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to