>From Savyasach Reddy <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj. Savyasach Reddy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187 )
Change subject: [ASTERIXDB-3564][STO]: Avoid halts on IO operation failures ...................................................................... Patch Set 29: (3 comments) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/metadata/schema/ObjectSchemaNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187/comment/09fff42c_19698745 PS23, Line 167: input.readByte(); > Please add a comment as to why this is needed (e.g., what are we skipping). Done File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IPageManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187/comment/931b5de1_71a9eed6 PS23, Line 51: returnAllPages > add java docs Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/util/ComponentUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187/comment/9afc2bd9_7da4beeb PS23, Line 177: ignored > when can these happen and why are they ignored? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: If253ea03f5baecbab226e527abb4267670a4233e Gerrit-Change-Number: 19187 Gerrit-PatchSet: 29 Gerrit-Owner: Savyasach Reddy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2025 16:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
