>From Savyasach Reddy <[email protected]>:

Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik Raj.
Savyasach Reddy has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187 )

Change subject: [ASTERIXDB-3564][STO]: Avoid halts on IO operation failures
......................................................................


Patch Set 30:

(2 comments)

File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponent.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187/comment/22bf26d0_06a8109f
PS23, Line 180: getIndex().activate();
> Is there a chance of failure after this? If yes, then this will set the 
> active flag of the index and […]
Done


File 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187/comment/3d37f4e9_de3373dd
PS23, Line 502: c != null
> When a large page is confiscated, pages are merged, and some are marked as 
> null. […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19187
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: If253ea03f5baecbab226e527abb4267670a4233e
Gerrit-Change-Number: 19187
Gerrit-PatchSet: 30
Gerrit-Owner: Savyasach Reddy <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Ritik Raj <[email protected]>
Gerrit-CC: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Ritik Raj <[email protected]>
Gerrit-Comment-Date: Tue, 25 Feb 2025 06:25:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Murtadha Hubail <[email protected]>
Comment-In-Reply-To: Savyasach Reddy <[email protected]>
Gerrit-MessageType: comment

Reply via email to