>From Ritik Raj <[email protected]>: Attention is currently required from: [email protected]. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19636 )
Change subject: [ASTERIXDB-3596][STO] Fix double comparison in range filters ...................................................................... Patch Set 3: (2 comments) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/filters/DoubleColumnFilterWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19636/comment/98c0fc73_90c98bca PS3, Line 51: public static double denormalizeDouble(long x) { : if (x >= 0) : return Double.longBitsToDouble(x); : else : return Double.longBitsToDouble((-(x + 1)) | 0x8000000000000000L); : } seems like not being used? if not, we can remove it. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19636/comment/ee848d0d_2aa1eebf PS3, Line 58: // This converts a double value into a long in such a way that the resulting long values preserve the natural ordering of the double values, and vice versa. : // The conversion is done by interpreting the double value as a 64-bit integer using IEEE 754 representation. : // If the number is non-negative, we simply return its raw bits as they follow the natural ordering. : // If the number is negative, the IEEE 754 representation is adjusted to ensure that the ordering is preserved. : // The adjustment is done in such a way that normalized(-INF) == LONG_MIN, normalized(-0.0) == -1, normalized(INF) == LONG_MAX and normalized(0.0) == 0. convert into java doc, rather than comment. and try to format the comment. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19636 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I702c4e1ef6c46e532cf64a874ec6a81bea3ebaad Gerrit-Change-Number: 19636 Gerrit-PatchSet: 3 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: [email protected] Gerrit-Comment-Date: Thu, 10 Apr 2025 16:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
